Bump FAB to 2.2.0 #8517
Merged
Bump FAB to 2.2.0 #8517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8517 +/- ##
==========================================
- Coverage 66.68% 66.51% -0.17%
==========================================
Files 449 449
Lines 22684 22687 +3
Branches 2366 2366
==========================================
- Hits 15126 15091 -35
- Misses 7420 7458 +38
Partials 138 138
Continue to review full report at Codecov.
|
etr2460
requested changes
Nov 7, 2019
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
can you include a test plan here? How did you verify that upgrading the dep worked?
Member
Author
|
@etr2460 updated pr description with my basic smoke test. Let me know if there's anything else I should take into account |
etr2460
approved these changes
Nov 12, 2019
Member
etr2460
left a comment
etr2460
left a comment
There was a problem hiding this comment.
lgtm, thanks for adding the test plan!
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Change log since 2.1.13:
Improvements and Bug fixes on 2.2.0
Fix, dpgaspar/Flask-AppBuilder#1157 Improve API get menu data performance
Fix, dpgaspar/Flask-AppBuilder#1143 [mvc] pagination
Fix, dpgaspar/Flask-AppBuilder#1147 [babel] crash with empty LANGUAGES config key
New, dpgaspar/Flask-AppBuilder#1116 Expose menu data as serializable objects
Fix, dpgaspar/Flask-AppBuilder#1127 MSSQL issue with pagination
Fix, dpgaspar/Flask-AppBuilder#1132 Add autofocus for login screen (dpgaspar/Flask-AppBuilder#1132)
Fix, dpgaspar/Flask-AppBuilder#1125 Support absence of the public role (dpgaspar/Flask-AppBuilder#1125)
New, dpgaspar/Flask-AppBuilder#1124 hide tabs when only 'Detail' (no related_views)
Fix, dpgaspar/Flask-AppBuilder#1119 ldap: safely retrieve error object when loggin exception
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS